Skip to content
This repository was archived by the owner on Feb 12, 2024. It is now read-only.

test: use pin tests#1405

Merged
alanshaw merged 3 commits intomasterfrom
test/pin
Jun 22, 2018
Merged

test: use pin tests#1405
alanshaw merged 3 commits intomasterfrom
test/pin

Conversation

@daviddias
Copy link
Member

No description provided.

@ghost ghost assigned daviddias Jun 20, 2018
@ghost ghost added the status/in-progress In progress label Jun 20, 2018

require('./pin')
require('./pin-set')
// require('./key-exchange')
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does anyone know why these tests were never being run? @richardschneider ??

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@diasdavid No idea, the tests should be run.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They weren't being picked up anywhere. I'll add them as a separate PR then.

@daviddias daviddias mentioned this pull request Jun 20, 2018
@daviddias daviddias requested a review from alanshaw June 20, 2018 17:03
License: MIT
Signed-off-by: Alan Shaw <alan@tableflip.io>
@ghost ghost assigned alanshaw Jun 21, 2018
Copy link
Member

@alanshaw alanshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I upped the timeout for teardown for the pin set tests and everything is 💚

@alanshaw alanshaw merged commit 2e94184 into master Jun 22, 2018
@ghost ghost removed the status/in-progress In progress label Jun 22, 2018
@alanshaw alanshaw deleted the test/pin branch June 22, 2018 07:55
@daviddias
Copy link
Member Author

Thank you @alanshaw ❤️

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants